New permission ClientsRead and new router middleware RequireAtLeastOnePermission #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, revoke ClientsManage from role User
…at a requester has at least one listed permission in order to access a given resource
mistahj67
reviewed
Jan 18, 2024
|
Nothing stands out to me. There's potential for some DRY work here but I feel like it's squeezing for the sake of abstraction so I'm happy to approve this as-is but feel free to refactor based on other comments. |
zinic
approved these changes
Jan 18, 2024
superlinkx
previously requested changes
Jan 18, 2024
@superlinkx It looks like this requested change was already made in #131 |
|
Oh, awesome! I'll go ahead and give this the thumbs up as is then |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new permission,
ClientsRead, is introduced and assigned to theUserrole. Additionally, theClientsManagepermission has been revoked from theUserrole.A new router middleware,
RequireAtLeastOnePermission, is introduced. This middleware forbids access to a resource unless the requester has at least one of the listed permissions. This is in contrast toRequirePermissionswhich forbids access to a resource unless the requester has all of the listed permissions.Motivation and Context
This change enables desired behavior in BloodHound Enterprise.
How Has This Been Tested?
Existing unit tests have been updated and new unit tests have been added.
Types of changes
Checklist: