Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert select schemagen changes #332

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: revert select schemagen changes #332

merged 1 commit into from
Jan 22, 2024

Conversation

zinic
Copy link
Contributor

@zinic zinic commented Jan 22, 2024

Description

This changeset reverts an overeager refactor that affected schemagen and resulted in a type name change.

Motivation and Context

This change is not required and should be reverted despite the effect being non-breaking.

How Has This Been Tested?

Local test suite and launching the application.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just sanity checking something that came out of our mock regeneration

packages/go/dawgs/graph/mocks/query.go Show resolved Hide resolved
@zinic zinic merged commit d30bc92 into main Jan 22, 2024
2 checks passed
@zinic zinic deleted the schemagen-fix branch January 22, 2024 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants