Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ESC 9A to the edge filter dialog #344

Merged
merged 12 commits into from
Jan 25, 2024
Merged

add ESC 9A to the edge filter dialog #344

merged 12 commits into from
Jan 25, 2024

Conversation

brandonshearin
Copy link
Contributor

Description

this small change adds the ESC 9A edge to the edge filtering dialog, which can be accessed from the pathfinding search box on the explore page. like other edges, it is checked by default.

Motivation and Context

we want the new 9A edge to be included in pathfinding searches by default. the way to do that is by adding an edge to edgeTypes.tsx.

How Has This Been Tested?

Screenshots (if appropriate):

the 9A edge appearing in the dialog, default checked:
Screenshot 2024-01-24 at 8 03 49 AM

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Copy link
Collaborator

@elikmiller elikmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy enough!

@brandonshearin brandonshearin enabled auto-merge (squash) January 25, 2024 16:31
@brandonshearin brandonshearin merged commit c6258b0 into main Jan 25, 2024
2 checks passed
@brandonshearin brandonshearin deleted the BED-4022 branch January 25, 2024 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants