Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: static analysis plumbing for BHCE #353

Merged
merged 8 commits into from
Jan 25, 2024
Merged

feat: static analysis plumbing for BHCE #353

merged 8 commits into from
Jan 25, 2024

Conversation

superlinkx
Copy link
Contributor

@superlinkx superlinkx commented Jan 25, 2024

Description

  • Adds a new static analysis pipeline to GitHub Actions to enforce our static analysis rules going forward
  • Resets the static analysis config to sane defaults. This includes moving some ignored rules to warnings so they can eventually be tackled.
  • Adds just analyze command using St Bernard. The results are filtered and prettified by jq for better local dev ergonomics (you can click the links to go directly to the line)
  • Includes fixes for triggered error rules

Motivation and Context

No broken windows

How Has This Been Tested?

  • Local runs of the analyzer match expectations and complete as expected
  • Pipeline tested several times to ensure consistent results

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@superlinkx superlinkx changed the title Dev env qol feat: static analysis plumbing for BHCE Jan 25, 2024
@superlinkx superlinkx marked this pull request as ready for review January 25, 2024 19:01
@zinic
Copy link
Collaborator

zinic commented Jan 25, 2024

👍

@superlinkx superlinkx enabled auto-merge (squash) January 25, 2024 19:11
@superlinkx superlinkx merged commit 7dea7cd into main Jan 25, 2024
3 checks passed
@superlinkx superlinkx deleted the dev-env-qol branch January 25, 2024 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants