-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support export logging #386
Changes from 46 commits
0e1d356
d0c6173
1d08960
6019c99
0f0d55a
3d65a85
86b77a3
22c3e8c
cf4b854
985d580
29673a9
a05ba51
cd78c04
9cb8a3d
e1d81bd
3ac13c1
fd32507
2a14ff5
602d04b
6fe1f94
6810bd3
0482b61
af01314
9ff9831
3902523
d744c31
061dc91
4cd2264
13f4160
2a2c839
cc16a11
2624969
c36c609
eb5e741
9c3b76b
0330679
de6bc2e
0719913
847c92c
ed025f5
8ec67ab
5ff9e33
b39f476
0185b1e
7e15c49
c5b2fd3
9874e26
deafa44
6666105
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replace our bespoke trace endpoint in the toolapi with the proper EDIT: added the old trace endpoint back due to how Acumen interacts with it. Will update acumen later and then properly remove this endpoint |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Kind of a dumb name, but allows us to add conditional audit logging a bit easier |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AuditableURL was needed to support passing the request url to the audit log logic that requires an |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Work by @zinic to plug a deadlock condition I hit locally. This cleans up the logic of this function in general, but should be reviewed carefully to ensure nothing was missed. Tests fine locally now |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove dead code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull the request URL for auditing purposes