Group management filtering #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/javascript/bh-shared-ui/src/components/AssetGroupEdit/AssetGroupEdit.tsx
Outdated
Show resolved
Hide resolved
packages/javascript/bh-shared-ui/src/components/AssetGroupFilters/AssetGroupFilters.tsx
Outdated
Show resolved
Hide resolved
...ges/javascript/bh-shared-ui/src/components/GroupManagementContent/GroupManagementContent.tsx
Show resolved
Hide resolved
packages/javascript/bh-shared-ui/src/components/AssetGroupFilters/FilterAutocomplete.tsx
Outdated
Show resolved
Hide resolved
…nagement-filtering
definitelynotagoblin
approved these changes
Feb 5, 2024
| const { screen } = await setup({ filterParams, availableNodeKinds }); | ||
| const checkbox = screen.getByTestId('asset-groups-custom-member-filter'); | ||
|
|
||
| expect((checkbox.firstChild as HTMLInputElement)?.checked).toBe(true); |
There was a problem hiding this comment.
Should we explicitly set the filterParams value to true here instead of trusting that the mock factory provides this value?
There was a problem hiding this comment.
Yeah great suggestion! And it's more explicit
definitelynotagoblin
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Filter section to Group Managment tab where one can filter on Node Type and custom member.
Motivation and Context
This should help with narrowing search results in the group management tab.
How Has This Been Tested?
Manual Tests. Adding unit and integration tests in a later PR
Screenshots (if appropriate):
Screen.Recording.2024-02-05.at.8.27.28.AM.mov
Types of changes
Checklist: