Remove ADCS feature flag gates #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlinkx
approved these changes
Feb 5, 2024
Comment on lines
61
to
65
| //Leaving this code here for re-enabling in future ADCS work | ||
| //adcsFlag, err := s.db.GetFlagByKey(appcfg.FeatureAdcs) | ||
| //if err != nil { | ||
| // return fmt.Errorf("error getting ADCS feature flag: %w", err) | ||
| //} |
There was a problem hiding this comment.
Recommend ripping this since it's both trivial and Git will keep track of it for us
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the ADCS feature flags in preparation for GA of ADCS
Motivation and Context
See description. The feature flag will still remain in play, but will only block upcoming ADCS work (B edges)
How Has This Been Tested?
Existing tests continue to work, post processing is working as expected
Screenshots (if appropriate):
Types of changes
Checklist: