Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify datapipe and test orphan file cleanup #391

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

zinic
Copy link
Collaborator

@zinic zinic commented Feb 6, 2024

Description

This is a continuation of work done earlier. Mostly clean up and a small refactor to pull additional complexity from the datapipe and add test coverage.

Motivation and Context

Further clean up from earlier datapipe refactors.

How Has This Been Tested?

Added additional unit tests to cover this refactor.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@zinic zinic force-pushed the BED-3046 branch 2 times, most recently from dce57f0 to 1428b7e Compare February 7, 2024 20:19
Copy link
Contributor

@rvazarkar rvazarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and extra testing is always great. A comment explaining how the ExpectedFile test works would be great as its not immediately obvious (at least to me)

@zinic zinic merged commit bbe3aa0 into main Feb 9, 2024
3 checks passed
@zinic zinic deleted the BED-3046 branch February 9, 2024 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants