Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixup migration visiblity for ordering #408

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

zinic
Copy link
Contributor

@zinic zinic commented Feb 9, 2024

Description

Fixups for migration visibility to allow for conditional ordering of migration application.

Motivation and Context

To enable better migration logic elsewhere in the application.

How Has This Been Tested?

Local testing.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@zinic zinic force-pushed the migration-order-fix branch 2 times, most recently from 42e2c03 to 4b2fe85 Compare February 9, 2024 23:07
@sircodemane
Copy link
Contributor

i'm a little fuzzy on the default graph setting vs asserting schema logic, but it sniffs good (pending one comment)

@zinic zinic force-pushed the migration-order-fix branch from 4b2fe85 to 40fe9d1 Compare February 12, 2024 16:45
@zinic zinic merged commit 98cc7b0 into stage/v5.6.0 Feb 12, 2024
3 checks passed
@zinic zinic deleted the migration-order-fix branch February 12, 2024 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants