Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group management node counts #409

Merged
merged 19 commits into from
Feb 20, 2024
Merged

Group management node counts #409

merged 19 commits into from
Feb 20, 2024

Conversation

benwaples
Copy link
Contributor

@benwaples benwaples commented Feb 12, 2024

Description

Implement a new endpoint, /members/counts, to get the count per node kinds in a environment+member group. This replaces calling /members for every node kind only to use the count value in the response.

Also, this backs off re-fetching member list, member counts, and asset groups on window focus. It adds noise to the API and isnt required for data in the Group Management Tab.

Motivation and Context

Calling /members for every node kind was expensive and slow in large environments.

How Has This Been Tested?

Manual tests, additional unit tests, and updated unit tests.

Screenshots (if appropriate): n/a

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@benwaples benwaples changed the base branch from BED-4106 to main February 12, 2024 18:26
@benwaples benwaples self-assigned this Feb 12, 2024
@benwaples
Copy link
Contributor Author

This PR builds off of: #397.

Once we get that merged in, Ill move this PR out of draft.

@benwaples benwaples marked this pull request as ready for review February 13, 2024 22:37
@benwaples benwaples force-pushed the group-management-node-counts branch 2 times, most recently from ee3153a to 672abc8 Compare February 13, 2024 23:14
@benwaples benwaples marked this pull request as draft February 13, 2024 23:16
@benwaples benwaples marked this pull request as ready for review February 14, 2024 00:31
@benwaples benwaples merged commit 70fe21b into main Feb 20, 2024
3 checks passed
@benwaples benwaples deleted the group-management-node-counts branch February 20, 2024 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants