-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group management node counts #409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR builds off of: #397. Once we get that merged in, Ill move this PR out of draft. |
benwaples
force-pushed
the
group-management-node-counts
branch
2 times, most recently
from
February 13, 2024 23:14
ee3153a
to
672abc8
Compare
…nagement-node-counts
…nagement-node-counts
packages/javascript/bh-shared-ui/src/components/AssetGroupEdit/AssetGroupEdit.tsx
Show resolved
Hide resolved
...ges/javascript/bh-shared-ui/src/components/GroupManagementContent/GroupManagementContent.tsx
Outdated
Show resolved
Hide resolved
definitelynotagoblin
approved these changes
Feb 15, 2024
packages/javascript/bh-shared-ui/src/components/AssetGroupFilters/AssetGroupFilters.tsx
Outdated
Show resolved
Hide resolved
…nagement-node-counts
…nagement-node-counts
…nagement-node-counts
…nagement-node-counts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a new endpoint,
/members/counts
, to get the count per node kinds in a environment+member group. This replaces calling/members
for every node kind only to use the count value in the response.Also, this backs off re-fetching member list, member counts, and asset groups on window focus. It adds noise to the API and isnt required for data in the Group Management Tab.
Motivation and Context
Calling
/members
for every node kind was expensive and slow in large environments.How Has This Been Tested?
Manual tests, additional unit tests, and updated unit tests.
Screenshots (if appropriate): n/a
Types of changes
Checklist: