Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feature flag default #411

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

mistahj67
Copy link
Contributor

@mistahj67 mistahj67 commented Feb 12, 2024

Description

The ADCS feature flag is defaulted to true in the migration, but needs to be defaulted to false.

Motivation and Context

This is to allow further ADCS development to be integrated without affecting existing installations. This feature flag may be re-enabled via the API for testing purposes.

How Has This Been Tested?

Migration ran and it set the FF to false

Screenshots (if appropriate):

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@mistahj67 mistahj67 changed the base branch from main to stage/v5.6.0 February 12, 2024 18:45
@mistahj67 mistahj67 merged commit 8f2ec84 into stage/v5.6.0 Feb 12, 2024
1 check passed
@mistahj67 mistahj67 deleted the fix-feature-flag-default branch February 12, 2024 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants