JSON Streaming #412
Merged
JSON Streaming #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests: add tests for validatemeta tag tests: fix a bad package declaration
superlinkx
previously requested changes
Feb 13, 2024
This can be reverted or modified further, it's only a quickly slapped together example for testing the parser
superlinkx
dismissed
their stale review
Resolved, but I haven't had a chance to fully review the logical changes and would like to re-review
urangel
reviewed
Feb 14, 2024
zinic
requested changes
Feb 14, 2024
cmd/api/src/test/integration/harnesses/adinboundcontrolharness.svg
Outdated
Show resolved
Hide resolved
mistahj67
reviewed
Feb 14, 2024
| return nil | ||
| } | ||
|
|
||
| func decodeGroupData(batch graph.Batch, reader io.ReadSeeker) error { |
There was a problem hiding this comment.
would tossing in the ingest function in decodeBasicData eliminate the need for these 3 special copy pasta ❄️ s?
There was a problem hiding this comment.
They take different types
zinic
approved these changes
Feb 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements JSON streaming in the ingest pipeline
Motivation and Context
Large JSON files were completely loaded into memory causing exhaustion issues. AzureHound dumps can easily be multiple GB, so this wasn't a sustainable way of reading data. With this change, we'll load all of the data by streaming json in memory instead, which massively lower memory consumption.
How Has This Been Tested?
Testing using 200+mb json files locally
Screenshots (if appropriate):
Types of changes
Checklist: