Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init property map if nil on ingest node #415

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

definitelynotagoblin
Copy link
Contributor

@definitelynotagoblin definitelynotagoblin commented Feb 13, 2024

Description

Initialize property map on node ingest if undefined in JSON input file.

Motivation and Context

https://specterops.atlassian.net/browse/BED-4076
This error occurs because we assume that the field "Properties" is defined on the ingest object.
We should either initialize it if it does not exist on processing or otherwise raise an error.

How Has This Been Tested?

Ingest run on data files containing both populated and null "Properties" fields.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@definitelynotagoblin definitelynotagoblin enabled auto-merge (squash) February 20, 2024 17:20
@definitelynotagoblin definitelynotagoblin merged commit 075dccd into main Feb 20, 2024
3 checks passed
@definitelynotagoblin definitelynotagoblin deleted the anemeth/init-nil-property-map branch February 20, 2024 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants