-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-4194: PG Migrator Testing #582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinic
reviewed
Apr 30, 2024
Looks like we got dinged with a merge conflict but otherwise so far so good. One minor nit for the in-progress work. |
maffkipp
added
tooling
This updates developer tooling
blocked
This pull request cannot be completed and should not be merged
labels
Jun 3, 2024
zinic
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes pass muster and there are no lingering conflicts. Pull!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for our migrator tool that handles importing nodes, edges, and kinds from neo4j into postgres. It also adds some minor refactors to the migrator itself to make it easier to test.
Motivation and Context
We are planning on using this migrator to assist in switching customers over to our postgres graph driver, but we want to make sure it has adequate test coverage first.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: