Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4194: PG Migrator Testing #582

Merged
merged 20 commits into from
Jan 10, 2025
Merged

BED-4194: PG Migrator Testing #582

merged 20 commits into from
Jan 10, 2025

Conversation

maffkipp
Copy link
Contributor

@maffkipp maffkipp commented Apr 25, 2024

Description

This PR adds integration tests for our migrator tool that handles importing nodes, edges, and kinds from neo4j into postgres. It also adds some minor refactors to the migrator itself to make it easier to test.

Motivation and Context

We are planning on using this migrator to assist in switching customers over to our postgres graph driver, but we want to make sure it has adequate test coverage first.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@maffkipp maffkipp self-assigned this Apr 25, 2024
@maffkipp maffkipp changed the title PG Migrator Testing BED-4194: PG Migrator Testing Apr 26, 2024
@zinic
Copy link
Contributor

zinic commented Apr 30, 2024

Looks like we got dinged with a merge conflict but otherwise so far so good. One minor nit for the in-progress work.

@maffkipp maffkipp marked this pull request as ready for review May 7, 2024 18:22
@maffkipp maffkipp marked this pull request as draft May 17, 2024 19:36
@maffkipp maffkipp added tooling This updates developer tooling blocked This pull request cannot be completed and should not be merged labels Jun 3, 2024
@zinic zinic marked this pull request as ready for review January 10, 2025 18:40
Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes pass muster and there are no lingering conflicts. Pull!

@zinic zinic merged commit 9e77c99 into main Jan 10, 2025
5 checks passed
@zinic zinic deleted the pg-migrate branch January 10, 2025 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked This pull request cannot be completed and should not be merged tooling This updates developer tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants