-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix healthcheck to not use env variable #864
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
I'm checking into this issue today. I actually think this looks correct, but running some scenarios to validate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on bare metal Linux/Docker and Docker Desktop for Mac, both worked exactly as expected with these changes. Thanks for fixing my bug!
@yannis-srl if you wouldn't mind rebasing on the latest main branch, that should fix the vulnerability reporting failure and allow for merging |
@yannis-srl - Thank you very much for finding and fixing this issue! I would love to send you a swag package to show our gratitude for your contributions to the product. If you can email me at shinck (AT) specterops (DOT) io with your shipping address and t-shirt size, I'll get that on its way! |
Description
Changing the healthcheck in the example docker compose to not use the environment variable which only specifies the exposed port.
Motivation and Context
This PR addresses: #862
This makes it possible to change the ports by setting the env variables, without bloodhound breaking.
How Has This Been Tested?
I have run it to avoid syntax errors by mistyping.
Screenshots (optional):
Types of changes
Checklist: