Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix healthcheck to not use env variable #864

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

yannis-srl
Copy link
Contributor

@yannis-srl yannis-srl commented Sep 17, 2024

Description

Changing the healthcheck in the example docker compose to not use the environment variable which only specifies the exposed port.

Motivation and Context

This PR addresses: #862

This makes it possible to change the ports by setting the env variables, without bloodhound breaking.

How Has This Been Tested?

I have run it to avoid syntax errors by mistyping.

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

@yannis-srl yannis-srl requested a review from a team as a code owner September 17, 2024 13:15
Copy link

github-actions bot commented Sep 17, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@yannis-srl
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@irshadaj irshadaj added the external This pull request is from an external contributor label Sep 17, 2024
@superlinkx
Copy link
Contributor

I'm checking into this issue today. I actually think this looks correct, but running some scenarios to validate

Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on bare metal Linux/Docker and Docker Desktop for Mac, both worked exactly as expected with these changes. Thanks for fixing my bug!

@superlinkx
Copy link
Contributor

@yannis-srl if you wouldn't mind rebasing on the latest main branch, that should fix the vulnerability reporting failure and allow for merging

@irshadaj irshadaj enabled auto-merge (squash) October 17, 2024 18:26
@irshadaj irshadaj merged commit c347ed2 into SpecterOps:main Oct 17, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@slokie-so slokie-so linked an issue Oct 21, 2024 that may be closed by this pull request
3 tasks
@StephenHinck
Copy link
Collaborator

@yannis-srl - Thank you very much for finding and fixing this issue! I would love to send you a swag package to show our gratitude for your contributions to the product. If you can email me at shinck (AT) specterops (DOT) io with your shipping address and t-shirt size, I'll get that on its way!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external This pull request is from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Healthcheck in example docker compose uses wrong port
4 participants