BED-5060: Prevent user from changing their own role/auth #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where user's password could get deleted Fix bug with GetAuthSecret not returning errnotfound
mistahj67
requested changes
Nov 26, 2024
Adjust update user form to hide fields
wes-mil
commented
Dec 2, 2024
| @@ -431,7 +444,7 @@ func (s *BloodhoundDB) CreateAuthSecret(ctx context.Context, authSecret model.Au | |||
| func (s *BloodhoundDB) GetAuthSecret(ctx context.Context, id int32) (model.AuthSecret, error) { | |||
| var ( | |||
| authSecret model.AuthSecret | |||
| result = s.db.WithContext(ctx).Find(&authSecret, id) | |||
| result = s.db.WithContext(ctx).First(&authSecret, id) | |||
There was a problem hiding this comment.
This database function was not properly returning an error when there was no auth secret with ID
mistahj67
approved these changes
Dec 3, 2024
ALCooper12
approved these changes
Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent a user from updating their own role or auth method within user configuration.
Also addresses two bugs discovered while addressing ticket:
Motivation and Context
This PR addresses: BED_5060
Why is this change required? What problem does it solve?
An admin user could change their own role to a role that is not privileged or change their own authentication method to something else. While this could be intentional, it largely caused issues with misconfigured SSO providers or accidental role changing. Effectively preventing that user from authenticating or having privilege. In the worst case, this could occur have occured while there was only a single admin user in the account.
How Has This Been Tested?
An admin user is created an then the user attempts to change their role through user configuration. On the UI these fields are now grayed out. Through the API, a PATCH request is made using an API token from an admin user attempting configure those fields. The API returns a 400 response now.
Test cases were added for the changes to database method UpdateUser.
Screenshots (optional):
Types of changes
Checklist: