Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5059 - Wrong edge name referenced in warning message #995

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

AD7ZJ
Copy link
Contributor

@AD7ZJ AD7ZJ commented Dec 3, 2024

Description

Correct edge names in log.Warnf() calls. Appears to be a copy/paste mistake.

Motivation and Context

This PR addresses: https://specterops.atlassian.net/browse/BED-5059

How Has This Been Tested?

Analysis of existing code. Imported default data and noticed a few warnings are triggered and now print out as expected:

bhe-api-1       | {"level":"info","time":"2024-12-02T23:07:47.050043946Z","message":"Finished building adcs cache"}
bhe-api-1       | {"level":"warn","time":"2024-12-02T23:07:47.232343975Z","message":"Post processing for ADCSESC6a: property isuserspecifiessanenabled: property not found"}
bhe-api-1       | {"level":"warn","time":"2024-12-02T23:07:47.232376467Z","message":"Post processing for ADCSESC6b: property isuserspecifiessanenabled: property not found"}
bhe-api-1       | {"level":"warn","time":"2024-12-02T23:07:47.305143517Z","message":"Post processing for ADCSESC6a: property isuserspecifiessanenabled: property not found"}
bhe-api-1       | {"level":"warn","time":"2024-12-02T23:07:47.305179267Z","message":"Post processing for ADCSESC6b: property isuserspecifiessanenabled: property not found"}

Previously, the same import would generate the following warnings:

bhe-api-1       | {"level":"info","time":"2024-12-02T23:33:46.877997562Z","message":"Finished building adcs cache"}
bhe-api-1       | {"level":"warn","time":"2024-12-02T23:33:47.127457818Z","message":"Post processing for GoldenCert: property isuserspecifiessanenabled: property not found"}
bhe-api-1       | {"level":"warn","time":"2024-12-02T23:33:47.1275032Z","message":"Post processing for GoldenCert: property isuserspecifiessanenabled: property not found"}
bhe-api-1       | {"level":"warn","time":"2024-12-02T23:33:47.216210006Z","message":"Post processing for GoldenCert: property isuserspecifiessanenabled: property not found"}
bhe-api-1       | {"level":"warn","time":"2024-12-02T23:33:47.216276536Z","message":"Post processing for GoldenCert: property isuserspecifiessanenabled: property not found"}

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@AD7ZJ AD7ZJ changed the title Correct edge names in log.Warnf calls for the ADCSESCx edges. BED-5059 - Wrong edge name referenced in warning message Dec 3, 2024
@AD7ZJ AD7ZJ merged commit 5544813 into main Dec 3, 2024
4 checks passed
@AD7ZJ AD7ZJ deleted the BED-5059 branch December 3, 2024 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants