chore: use helper func for LookupSidType

SpecterOps · Oct 4, 2022 · 9086c65 · 9086c65
1 parent 10d4c20
commit 9086c65
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/CommonLib/LDAPUtils.cs b/src/CommonLib/LDAPUtils.cs
@@ -220,15 +220,12 @@ public Label LookupSidType(string sid, string domain)
         {
             if (Cache.GetIDType(sid, out var type))
                 return type;
-
-            var hex = Helpers.ConvertSidToHexSid(sid);
-            if (hex == null)
-                return Label.Base;
-
+
             var rDomain = GetDomainNameFromSid(sid) ?? domain;
+            _log.LogInformation("looking up sid {sid} in domain {domain}", sid, domain);
 
             var result =
-                QueryLDAP($"(objectsid={hex})", SearchScope.Subtree, CommonProperties.TypeResolutionProps, rDomain)
+                QueryLDAP(CommonFilters.SpecificSID(sid), SearchScope.Subtree, CommonProperties.TypeResolutionProps, rDomain)
                     .DefaultIfEmpty(null).FirstOrDefault();
 
             type = result?.GetLabel() ?? Label.Base;