#10 cli default #79
#10 cli default #79
Conversation
…guments and check required arguments after parsing
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=========================================
Coverage ? 71.42%
=========================================
Files ? 11
Lines ? 280
Branches ? 46
=========================================
Hits ? 200
Misses ? 80
Partials ? 0Continue to review full report at Codecov.
|
|
The functionality looks good. It will needs tests before it gets accepted though. @jamesr73 Do you want to write the tests, or should we ask for contributors? |
|
Wow, been a while since I looked at this, and now I have conflicts 😏 Testing these changes will need tests for the CLI in the first instance. And they may well require an additional change for Commander #297. Let me take a look and get back to you. It's probably also worth upgrading the commander dependency, newest should support sub command aliases directly. Thoughts? |
Sync with head
…pencerCDixon#10-cli-default * 'master' of https://github.com/jamesr73/redux-cli: Starting development on 2.0 1.9.0 Adds yarn and updates package.json to not use explicit .bins Fixes redux g Fix example for .reduxrc Fix additional instances of typo in readme.md Fix typo in readme.md fix: } doesn't ( in blueprint file. guess it's a mistake :) Changed error message mentioned in SpencerCDixon#35 Fixed typo in readme code example Releases v1.8.0 with dry run support added test for writeWouldCreate add dry run option for redux generate Adds changelog updates to readme 1.7.0 Adds -U option to 'new' command in order to generate a UI Kit boilerplate Fix readme typo Adds a flag to new command for using the redux-cli-boilerplate 1.5.1 # Resolved Conflicts: # src/cli/redux-generate.js # src/cli/redux-new.js
|
Resolved my conflicts. I can write tests but I'm thinking it's worth waiting until #99 is merged. |
|
Is there any need for this given #110? |
|
No, #110 supersedes this. |
Addresses #10
Adds checks for required arguments and outputs help if they are missing. Reports on unknown commands.
Syncs up command descriptions between top-level and sub-command level usage.