-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gradle version to 7.4.2 #14
Open
hanslovsky
wants to merge
15
commits into
SpencerPark:master
Choose a base branch
from
hanslovsky:try-upgrade-gradle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests fail
Is it ok to remove nested here?
maybe
Additional action of task ':installKernel' was implemented by the Java lambda 'io.github.spencerpark.jupyter.gradle.InstallKernelTaskAction3738Lambda/0x0000000100ed4450'. Reason: Using Java lambdas is not supported as task inputs. Please refer to https://docs.gradle.org/7.4.2/userguide/validation_problems.html#implementation_unknown for more details about this problem. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.4.2/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to build SpencerPark/IJava with Java 17. Java 17 is only [supported with gradle 7.3+](https://docs.gradle.org/current/userguide/compatibility.html. Bumping the gradle version in IJava also required changes in the Jupyter-kernel-installer-gradle. I was able to make the changes to both repositories to build an IJava jupyter kernel with Java 17 support (PR for IJava will follow soon). This PR contains my changes to bump the gradle version to 7.4.2 in Jupyter-kernel-installer-gradle. I am not super familiar with this repository or gradle plugin development so some of my changes may be naive or plain wrong. @SpencerPark, please let me know what changes you would like to see.