Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated stuff #1265

Merged
merged 66 commits into from
Sep 26, 2023
Merged

Remove deprecated stuff #1265

merged 66 commits into from
Sep 26, 2023

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Dec 12, 2022 •
edited
Loading

This pr removed the stubs for deprecated stuff.

especially spynnaker8

Must be done after:
SpiNNakerManchester/microcircuit_model#25
SpiNNakerManchester/SpiNNGym#58

tested by:
SpiNNakerManchester/IntegrationTests#170

@Christian-B Christian-B mentioned this pull request Dec 12, 2022
Closed
@coveralls
Copy link

coveralls commented Sep 25, 2023 •
edited
Loading

Coverage Status

coverage: 61.322% (+0.006%) from 61.316% when pulling 6daf369 on remove_deprecated into 0f8e5b7 on master.

andrewgait
andrewgait approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me, though there is more deprecated stuff that I'm aware of that's still in (e.g. Projection.getWeights(..)); that can always go in a later PR, of course.

@Christian-B Christian-B merged commit 181d9d7 into master Sep 26, 2023
6 checks passed
@Christian-B Christian-B deleted the remove_deprecated branch September 26, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewgait andrewgait andrewgait approved these changes

Assignees

@andrewgait andrewgait

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christian-B @coveralls @andrewgait