Skip to content

Allow plot_probe not to plot on axes, but just return polycollections #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jakeswann1
Copy link

Retains previous default behaviour, but adds the option not to plot the collections on an axis, but just to return them. This is useful for incorporating the probe layout into other plots (such as SpikeInterface widgets).

@samuelgarcia
Copy link
Member

Hi Jake.
I understand the need but I find the design a bit complicated and the option not super intuitive.
Why not having a clear separated function that create the poly that would used internaly by plot_probe and also by you specific need ?
Maybe it is more changes, I don't known. I will try to have a deeper look

@jakeswann1
Copy link
Author

Hi Sam, thanks! That makes a lot of sense, I'll work on a refactor

@jakeswann1
Copy link
Author

Hi @samuelgarcia, I think this is ready for review - split into a new function as suggested

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (35d2b19) to head (4604a7e).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/probeinterface/plotting.py 85.71% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   89.66%   89.68%   +0.02%     
==========================================
  Files          12       12              
  Lines        1954     1959       +5     
==========================================
+ Hits         1752     1757       +5     
  Misses        202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants