-
Notifications
You must be signed in to change notification settings - Fork 44
Allow plot_probe not to plot on axes, but just return polycollections #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi Jake. |
Hi Sam, thanks! That makes a lot of sense, I'll work on a refactor |
Hi @samuelgarcia, I think this is ready for review - split into a new function as suggested |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 89.66% 89.68% +0.02%
==========================================
Files 12 12
Lines 1954 1959 +5
==========================================
+ Hits 1752 1757 +5
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Retains previous default behaviour, but adds the option not to plot the collections on an axis, but just to return them. This is useful for incorporating the probe layout into other plots (such as SpikeInterface widgets).