Use strings as ids in generators #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
requested changes
Dec 19, 2024
Co-authored-by: Alessio Buccino <[email protected]>
Co-authored-by: Alessio Buccino <[email protected]>
samuelgarcia
reviewed
Jan 6, 2025
| @@ -1177,7 +1179,8 @@ def __init__( | |||
| self.refractory_period_seconds = np.full(num_units, self.refractory_period_seconds, dtype="float64") | |||
|
|
|||
| self.segment_seed = seed | |||
| self.units_seed = {unit_id: self.segment_seed + hash(unit_id) for unit_id in range(num_units)} | |||
| self.units_seed = {unit_id: abs(self.segment_seed + hash(unit_id)) for unit_id in unit_ids} | |||
There was a problem hiding this comment.
Suggested change
| self.units_seed = {unit_id: abs(self.segment_seed + hash(unit_id)) for unit_id in unit_ids} | |
| self.units_seed = {unit_id: self.segment_seed + abs(hash(unit_id)) for unit_id in unit_ids} |
|
I am OK with this. |
alejoe91
reviewed
Jan 7, 2025
alejoe91
approved these changes
Jan 7, 2025
|
Thanks for the review, guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the maintenance meeting of 2024/12/17.
So unless the change was very simple I decided to keep the tests as they were in most of the large integration tests. This is easier to change and is less likely to bring about conflicts when merging this. This was done by renaming the channels from the now default strings to integers.