Make time_range conversion to array dtype float64
#3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, apologies I was using Githubs web interface to raise the commit and it did it from this repo not my fork, please let me know if its a problem and I will redo |
alejoe91
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the most edge-case, inconsequential bugs ever: If your recording is < 1 second long and if you specify
time_range=(0, 1)instead of(0, 1.0)then the cast fromtupletoarraywill generate anintarray. Whent_endis assigned to it it will round to0leading totime_range=(0, 0)and failure to retrieve traces.This is for a super-short example file I am using😅