Add splitting functionality to curation and SortingAnalyzer
#3817
+1,069
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
commented
Mar 28, 2025
Comment on lines
+597
to
+599
| old_template = arr[self.sorting_analyzer.sorting.ids_to_indices([split_unit_id])[0], ...] | ||
| new_indices = np.array([new_unit_ids.index(unit_id) for unit_id in new_splits]) | ||
| new_array[new_indices, ...] = np.tile(old_template, (len(new_splits), 1, 1)) |
There was a problem hiding this comment.
@samuelgarcia this needs to be discussed. What should we do if the waveforms extension is not there? The current behavior is copying, but we mught want to force recompute here
There was a problem hiding this comment.
maybe add warning here!
|
This is amazing camarade. I would do first a PR to focus only on the format. And then merge this one. |
|
I did camarade! #3760 |
alejoe91
commented
Jul 17, 2025
| new_unit_ids : list | None, default: None | ||
| Optional new unit_ids for merged units. If given, it needs to have the same length as `merge_unit_groups`. | ||
| If None, new ids will be generated. | ||
| new_id_strategy : "append" | "take_first" | "join", default: "append" |
There was a problem hiding this comment.
Suggested change
| new_id_strategy : "append" | "take_first" | "join", default: "append" | |
| new_id_strategy : "append" | "split", default: "append" |
alejoe91
commented
Jul 17, 2025
| self, | ||
| split_units: dict[list[str | int], list[int] | list[list[int]]], | ||
| new_unit_ids: list[list[int | str]] | None = None, | ||
| new_id_strategy: str = "append", |
There was a problem hiding this comment.
Add splitting_mode to deal with templates recomputation
alejoe91
commented
Jul 17, 2025
alejoe91
commented
Jul 17, 2025
Comment on lines
+71
to
+74
| full_spike_indices = [] | ||
| for label in np.unique(self.labels): | ||
| label_indices = np.where(self.labels == label)[0] | ||
| full_spike_indices.append(label_indices) |
There was a problem hiding this comment.
maybe make a helper function that returns a dict of indices given an array
alejoe91
commented
Jul 17, 2025
| # we propagate random spikes to avoid random spikes to be recomputed | ||
| extension_dict_ = extension_dict_split.copy() | ||
| extension_dict_.pop("random_spikes") | ||
| analyzer_hard.extensions["random_spikes"] = analyzer_split.extensions["random_spikes"] |
There was a problem hiding this comment.
do a copy and ref to the analyzer here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3760
Implements splitting functionality in:
sorting_tools:apply_splits_to_sortingSortingAnalyzer:.split_units()AnalyzerExtension:_split_extension_data(implemented function for all extensions and extended tests)