Add concatenated
to _get_data
for amps and locs; use in _get_amplitudes_by_units
#4029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4028
PR implements a
concatenated
argument inget_data
method for thespike_ampltiudes
andspike_locations
extensions. This returns the data per unit, concatenated per segment. I think this is a helpful thing to have, and was easy to implement.Then used this new functionality in
_get_amplitudes_by_units
.Benchmarked using:
On main: 1.68s
This PR, without numba: 1.13s
This PR, with numba: 0.0806s
So a 20x speedup if numba is around :)