Skip to content

Templates.is_scaled > Templates.is_in_uV #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samuelgarcia
Copy link
Member

This needed to be done after #3794.
At the moement is is a simple replace in the entire code.
There are many return_scaled to be changed in return_in_uV but @zm711 already started to change some in #4033.
So lets wait #4033 to be merged first and then lets continue working on this.

I think we will need to make some logic for readi backward compatible Templates saved before 0.103.0

@samuelgarcia samuelgarcia added this to the 0.103.0 milestone Jul 7, 2025
@zm711
Copy link
Member

zm711 commented Jul 7, 2025

I was just commenting on this deprecation. We hadn't officially discussed deprecation strategy for scaled -> is_in_uV, which I think we should. Agree with backward compatability though! It was a pain once when we did a dep and all my analyzers started erroring. I forget what it was. nbefore maybe?

@h-mayorquin
Copy link
Collaborator

This is great, thanks Sam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants