Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-launcher lib leaking sockets when run without launcher #548

Open
p2004a opened this issue Sep 23, 2022 · 1 comment
Open

spring-launcher lib leaking sockets when run without launcher #548

p2004a opened this issue Sep 23, 2022 · 1 comment

Comments

@p2004a
Copy link
Contributor

p2004a commented Sep 23, 2022

When running Chobby with libs/spring-launcher/api_spring_launcher_loader.lua loaded (like BYAR-Chobby), but without the spring-lobby actually running e.g manual run:

./spring -isolation -write-dir ~/Documents/Beyond\ All\ Reason -menu rapid://byar-chobby:test

The library is not cleaning up sockets after connection fails, this causes reaching high number of open descriptors, and game can crash with:

[t=00:00:15.766676][f=-000001] [LuaMenu] Error: In Update(): [string "libs/spring-launcher/luaui/widgets/api_spri..."]:93: attempt to index upvalue 'client' (a nil value)
[t=00:00:15.766724][f=-000001] [LuaMenu] Error: Removed widget: <spring-launcher>
[t=00:00:15.807952][f=-000001] [CrashHandler] Error: Segmentation fault in Spring 105.1.1-1214-gcf8d087 BAR105
[t=00:00:15.807995][f=-000001] [CrashHandler] Error: Halted Stacktrace for Spring 105.1.1-1214-gcf8d087 BAR105 (SIGSEGV) using libunwind:
[t=00:00:15.857624][f=-000001] [CrashHandler] Warning: [TranslateStackTrace] addr2line not found!

Workaround is to increase the limit on file descriptors with ulimit -Sn 50000 but it's still annoying.

@Beherith not sure if belongs here or in BYAR-Chobby repo.

@Beherith
Copy link
Contributor

Entirely depends on wether byarchobby overrides libs/spring-launcher/api_spring_launcher_loader.lua :) if yes, then well have to fix it our side :) though the filename doesnt indicate an area of chobby im familiar with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants