Fix socket leaks and bad error condition checks. #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
Cherry picked from Spring-Chobby#560, itself a backport of beyond-all-reason/BYAR-Chobby#827
note: untested here! the changes should be safe but always good someone tests before applying, otherwise check the code to see it's safe. (I think so but I might have overlooked smth, also I only tested on linux).
Best way to test is running without the launcher (I do it as documented here), also can try with network disconnected. Also check with the launcher ofc to see it still works under normal conditions.
Please reach back if you see any issues.
Related issues