-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpringBoard-ZK replacement candidate #423
base: master
Are you sure you want to change the base?
Conversation
…anges are needed to implement a populate function that works on groupfields.
… added to player window. mex, startbox added to model.lua.
…startboxes lua files. Also added an option to only export heightmap. *Done through a button the info tab in misc **done through export menu options, did not yet add to export spring archive option.
…, unpathable = red), so that heightmap can be viewed and smoothed more usefully from SpringBoard.
I haven't had the time to take a detailed look at this yet, need a bit of time due to the size of the PR. I did notice that the indent/formatting was quite a bit off in some places. Can you run luacheck on this? I also did a quick CI fix yesterday, removing Travis in favor of GitHub actions. Can you merge those changes in to ensure your PR runs on the CI as well? I'll take a proper look as soon as I have some time! |
roger that, will fix in the next few days |
A look at some of the features: Metal spot editing
Btw, here's what I made some time ago: https://www.youtube.com/watch?v=Afav3o8Z5oY&ab_channel=GajoPetrovi%C4%87
Start box editing
Other
After this my next step will be to take a look a detailed look at the code, but from what I can suggest now is a refactor of managers (mex_manager, startbox_manager) to s11n object bridge. PS: This PR feels a bit large and might take a while to merge. Maybe it would be better to split it into smaller ones? |
--Mex and Startbox X-Mirror and Z-Mirror aren't be mutually exclusive -- although if you click both I suppose it becomes a 180 degree rotation instead. I could add something separately where you can define what kind of symmetry you want, as you would almost always want the same type of symmetry for all the metal spots. The other issues make sense. --Other Thank you for the detailed reply. I'm sorry I didn't get to the code yet -- I have installed luacheck now and it should work hopefully, and should have time on wednesday/thursday to fix those issues at least. If I can get the s11n stuff working I will split it into multiple PRs as I do so. |
This is just SpringBoard-Core, souped up a bit for ZK. Putting it as a draft pull-request here, because I think that is more meaningful than trying to create something at SpringBoard-ZK, as I have made additions to some files.
Summary:
Metal Spot and Startbox add, edit, importing, exporting, save, load etc.
-Additional states, classes and commands to make this possible as well as some edits to existing scripts.
Also a custom infoPath for ZK, and exporting of heightmaps only.