nipapd: Close LDAP connection after authentication #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LDAP auth backend never explicitly closed the connection to the LDAP server, when meant that it was kept open until the auth object timed out from the auth cache which can take some time. Now LDAP connections are closed once the authentication is done.
houndci-bot
reviewed
Jan 31, 2024
| except (ldap.CONNECT_ERROR, ldap.SERVER_DOWN) as exc: | ||
| self._logger.error('Attempted to start TLS with ldap server but failed.') | ||
| self._logger.exception(exc) | ||
| raise AuthError('Unable to establish secure connection to ldap server') |
There was a problem hiding this comment.
line too long (87 > 79 characters)
| if self._ldap_search_conn is not None: | ||
| self._ldap_search_conn.start_tls_s() | ||
| except (ldap.CONNECT_ERROR, ldap.SERVER_DOWN) as exc: | ||
| self._logger.error('Attempted to start TLS with ldap server but failed.') |
There was a problem hiding this comment.
line too long (89 > 79 characters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LDAP auth backend never explicitly closed the connection to the LDAP server, when meant that it was kept open until the auth object timed out from the auth cache which can take some time.
Now LDAP connections are closed once the authentication is done.