Allow running as admin in Wine #1868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaisbetts
reviewed
Nov 24, 2023
anaisbetts
requested changes
Nov 24, 2023
|
Changes applied. |
The admin privileges check introduced in Squirrel#254 prevents working at all in Wine, which always reports admin privileges. Since there's no danger of causing permissions problems in that case, allow it as a special case. Hopefully closes Squirrel#1720.
|
Additional change applied: |
|
Fixed this up manually and merged as aaec357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admin privileges check introduced in #254 prevents working at all in Wine, which always reports admin privileges. Since there's no danger of causing permissions problems in that environment, allow it as a special case.
Hopefully closes #1720.