add debug logging for logging that takes up a lot of space #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwnik
reviewed
Sep 14, 2023
| @@ -71,7 +71,7 @@ def extract(item): | |||
| return dict(filter(None, map(extract, header.splitlines()))) | |||
|
|
|||
| def _get_article(self, url): | |||
| logger.info("Fetching {}".format(url)) | |||
| logger.debug(f"Fetching {url}") | |||
There was a problem hiding this comment.
strictly speaking, when logging you should use params, like logger.debug("Fetching %s", url). It's fine here, but can potentially be a problem if casting url to a string is a slow or costly operation - with fstrings it's always done, but when provided as an argument it only does it when needed (i.e. log level == 'debug'). Again - here it's fine, but it's worth bearing in mind
There was a problem hiding this comment.
Oh, I see, I hadn't thought of that
main.py
Outdated
| @@ -74,7 +74,7 @@ def generate_jsonl_files(self, *names): | |||
| assert not missing, f"{missing} are not valid dataset names" | |||
| for name in names: | |||
| dataset = get_dataset(name) | |||
| print(dataset.to_jsonl()) | |||
| logger.info(dataset.to_jsonl()) | |||
There was a problem hiding this comment.
logger.info("%s", dataset.to_jsonl()), or logger.info(str(dataset.to_jsonl())). logger.info expects a string as its first argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids logger.info-ing all items in a source, and instead logs some constant amount of time per source, rather than proportional to its length, with the default logger level (info). if you're debugging you can set that to "DEBUG" for more info.