Allow chat items to be deleted #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwnik
commented
Oct 17, 2023
| @@ -175,7 +175,7 @@ def make_memory(settings, history, callbacks): | |||
| return_messages=True, | |||
| callbacks=callbacks | |||
| ) | |||
| memory.set_messages(history) | |||
| memory.set_messages([i for i in history if i.get('role') != 'deleted']) | |||
There was a problem hiding this comment.
Make sure the LLM only sees non deleted items
| self._last_save = time.time() | ||
| except SQLAlchemyError as e: |
There was a problem hiding this comment.
there's an interesting Heisenbug with sessions being dropped - this won't fix it, but at least won't break the chat when it happens. It only happens when the chatbot isn't used for a long period of time, which hopefully shouldn't be an issue once things start being used?
An objection can be raised that this will result in interactions not getting logged, which is an issue, but not a pressing one, as this is only for logging purposes, and should only happen if the error occurs and then the worker is shut down - otherwise the interactions will be saved the next time something happens, as they're saved in batches anyway
mruwnik
requested review from
Aprillion,
chriscanal,
FraserLee,
ccstan99,
henri123lemoine and
Thomas-Lemoine
Aprillion
reviewed
Oct 18, 2023
Aprillion
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was uncertain whether to just delete any removed history items and totally forget about them, or to just soft delete them. The hard delete is nice in that it's a lot simpler, but has the downside that it would totally mess up the history which gets logged to the database. I considered having a proper changelog type thingy, which would allow one to recreate the whole session, but decided against it as it would get very complicated. On the other hand, the current logging implementation adds a number saying which interaction this is, based on the history length. An alternative to this would be to always query the database before writing, to get the number of interactions in this session.
I went with a soft delete, as that can be used later on to make an interactive session viewer, which is something I wanted to do anyway, to play about with seeing how different prompts and settings effect things.