proper removal of previous entries #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwnik
commented
Nov 4, 2023
| session_id = request.json.get('sessionId') | ||
| history = request.json.get('history', []) | ||
| settings = request.json.get('settings', {}) | ||
|
|
||
| if query is None: |
There was a problem hiding this comment.
this allows querying by:
- just a query string
- a query string + history
- just history (as the last item is going to be the query)
mruwnik
requested review from
Aprillion,
chriscanal,
FraserLee,
ccstan99,
henri123lemoine and
Thomas-Lemoine
Aprillion
reviewed
Nov 5, 2023
| setQuery(v); | ||
| onQuery && onQuery(v); | ||
| }} | ||
| abortSearch={() => controller.abort()} |
There was a problem hiding this comment.
if multiple things are started (e.g. <Followups onClick={...}>, you only want to abort the last one?
There was a problem hiding this comment.
you're right - fixed
Aprillion
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a lot of reshuffling of the code. The previous code would display a history of previous interactions, each of which could be deleted, but this wouldn't have any effect on the current search. Which was annoying when you wanted to delete the last response and try again - it would delete it, but then you'd still have to copy your search phrase over.
Now when the last item is deleted, it will return to editing the previous query