Qa endpoint #128
Merged
Qa endpoint #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mruwnik
commented
Nov 7, 2023
mruwnik
commented
- adds optional comments to the QA page
- fixes bug with LangChain
- auto adjusts the history and context fraction to make sure their sum is < 1
- adds option of using new GPT-4-Turbo
mruwnik
requested review from
Aprillion,
chriscanal,
FraserLee,
ccstan99,
henri123lemoine and
Thomas-Lemoine
Aprillion
previously approved these changes
Nov 8, 2023
|
|
||
| if (field == "contextFraction") { | ||
| history = Math.min(history, Math.max(0, 1 - context - bufferFraction)); | ||
| context = val; |
There was a problem hiding this comment.
why using the old value of context in the history formula, why not val?
| (acc, [path, val]) => ({ ...acc, ...updateIn(settings, path, val) }), | ||
| settings | ||
| ) | ||
| ); |
There was a problem hiding this comment.
not in this PR, but the local state settings could not be derived from URL? sounds like asking for trouble trying to synchronize 2 places on write instead of deriving state from 1 source of truth 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.