QA requests #556

StampyAI · Mar 27, 2024 · 8b67900 · 8b67900
1 parent 47e3555
commit 8b67900
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/app/components/Article/FeedbackForm/feedbackForm.css b/app/components/Article/FeedbackForm/feedbackForm.css
@@ -1,4 +1,5 @@
 .feedback-container {
+  max-width: 384px;
   padding: var(--spacing-32);
 }
 .select-option {
@@ -13,7 +14,6 @@
 }
 
 .feedback-form {
-  width: 100%;
   position: relative;
   color: var(--colors-cool-grey-600);
   z-index: 2;
@@ -50,7 +50,7 @@
 .composite-button > .feedback-form {
   position: absolute;
   display: none;
-  transform: translate(-11vw, var(--spacing-56));
+  transform: translate(-9vw, var(--spacing-56));
   margin: var(--spacing-24);
 }
 .composite-button > .feedback-form.show {

diff --git a/app/components/Article/index.tsx b/app/components/Article/index.tsx
@@ -68,7 +68,7 @@ const ArticleFooter = (question: Question) => {
             pageid={question.pageid}
             showText={true}
             actionType={ActionType.UNHELPFUL}
-            onSuccess={() => setShowFeedbackForm(true)}
+            onClick={() => setShowFeedbackForm(true)}
           />
           <div className={['action-feedback-text', showFeedback ? 'show' : ''].join(' ')}>
             Thanks for your feedback!

diff --git a/app/newRoot.css b/app/newRoot.css
@@ -530,6 +530,7 @@ ol {
   }
 } /* end mobile */
 p,
+textarea,
 button {
   font-family: Poppins;
 }

diff --git a/app/routes/questions.actions.tsx b/app/routes/questions.actions.tsx
@@ -93,13 +93,15 @@ type Props = {
   children?: ReactNode | ReactNode[]
   [k: string]: unknown
   onSuccess?: () => void
+  onClick?: () => void
 }
 export const Action = ({
   pageid,
   actionType,
   showText = true,
   children,
   onSuccess,
+  onClick,
   ...props
 }: Props) => {
   const [remixSearchParams] = useSearchParams()
@@ -131,7 +133,9 @@ export const Action = ({
 
   const handleAction = async (e: MouseEvent<HTMLElement>) => {
     e.preventDefault()
-
+    if (onClick) {
+      onClick()
+    }
     setActionTaken(!actionTaken)
 
     // This sort of cheats - if more than 1 request is sent per second (or some other such time
@@ -169,7 +173,10 @@ export const Action = ({
       {children}
       <Button className={className}>
         <Icon />
-        <span className={actionTaken ? 'teal-500' : 'grey'}> {showText && title}</span>
+        <p className={[actionTaken ? 'teal-500' : 'grey', 'small'].join(' ')}>
+          {' '}
+          {showText && title}
+        </p>
       </Button>
     </Form>
   )