Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use glossary table #278

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Use glossary table #278

merged 4 commits into from
Jul 11, 2023

Conversation

mruwnik
Copy link
Collaborator

@mruwnik mruwnik commented Jul 10, 2023

#272
Uses the new glossary table

Aprillion
Aprillion requested changes Jul 11, 2023
View reviewed changes
app/server-utils/stampy.ts Outdated Show resolved Hide resolved
@mruwnik mruwnik requested a review from Aprillion July 11, 2023 09:39
Aprillion
Aprillion reviewed Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@Aprillion Aprillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better now 👍

discriminating union with runtime assertions would be even better to make sure we get what we expect instead of just trusting Coda and doing type assertions, but that can be improved later

app/routes/questions/$question.tsx Outdated Show resolved Hide resolved
@mruwnik mruwnik merged commit 4e22e84 into master Jul 11, 2023
@mruwnik mruwnik deleted the glossary-table branch July 11, 2023 11:23
@Aprillion Aprillion mentioned this pull request Jul 11, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aprillion Aprillion Aprillion approved these changes

@ccstan99 ccstan99 Awaiting requested review from ccstan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mruwnik @Aprillion