load all tags before questions #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwnik
commented
Jul 18, 2023
| @@ -22,6 +22,7 @@ import {reloadInBackgroundIfNeeded} from '~/server-utils/kv-cache' | |||
|
|
|||
| export const loader = async ({request}: Parameters<LoaderFunction>[0]) => { | |||
| try { | |||
| await loadTags(request) | |||
There was a problem hiding this comment.
double the initial loading time :/
The problem here is that questions don't download the metadata of their tags, only the name. So the questions need to fetch tags before being able to filter out internal ones. This adds an initial tax, rather than per request, so potentially better?
There was a problem hiding this comment.
did you check /questions/cache on localhost that it's cached, please?
Aprillion
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.