fix glossary bugs #297
Merged
fix glossary bugs #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprillion
approved these changes
Aug 6, 2023
| @@ -173,7 +173,7 @@ export function Question({ | |||
| const updateTextNodes = (el: Node, textProcessor: (node: Node) => Node) => { | |||
| Array.from(el.childNodes).forEach((child) => updateTextNodes(child, textProcessor)) | |||
|
|
|||
| if (el.nodeType == Node.TEXT_NODE && el.textContent && el?.parentElement?.tagName != 'A') { | |||
There was a problem hiding this comment.
please check git commit for the old code, it was fixing (workarounding?) some previous bug - not sure which, but it deserves to be re-tested that removing the last condition won't reintroduce the previous bug 🤞
There was a problem hiding this comment.
it was checking whether the glossary item is part of a link, so it didn't display links as glossary items. But apparently the editors want that... :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StampyAI/GDocsRelatedThings#54
StampyAI/GDocsRelatedThings#55
StampyAI/GDocsRelatedThings#56