Add basic banner functionality #300
Conversation
| @@ -263,6 +288,10 @@ export const loadQuestionDetail = withCache('questionDetail', async (question: s | |||
| const {data} = await loadTags('NEVER_RELOAD') | |||
| allTags = Object.fromEntries(data.map((r) => [r.name, r])) as Record<string, Tag> | |||
| } | |||
| if (Object.keys(allBanners).length === 0) { | |||
There was a problem hiding this comment.
feel free to create an issue where you collect all notes about what needs to be double checked and loaded in correct order currently and deserves simplification, I might get to it during aisafety.com hackathon 🤞
| tags, | ||
| } = questionProps | ||
| const title = | ||
| codaStatus && codaStatus !== QuestionStatus.LIVE_ON_SITE ? `WIP - ${codaTitle}` : codaTitle |
There was a problem hiding this comment.
a banner can be displayed for non published questions, rather than the WIP -
There was a problem hiding this comment.
"can be" or "is" actually displayed for all current WIP questions?
There was a problem hiding this comment.
they all have the appropriate banner set, so it's mainly a matter of deciding whether that's the way to go. The parser is already updated to do so
There was a problem hiding this comment.
color scheme in the current screenshot would not be my first choice, but if it gives more power to the editors to customize the banner instead of hardcoded WIP -, it sounds like a step in good direction 👍
There was a problem hiding this comment.
oh, this most certainly is a bad choice - I pretty much just plopped random colours there to "encourage" someone else to choose decent ones :D
| tags, | ||
| } = questionProps | ||
| const title = | ||
| codaStatus && codaStatus !== QuestionStatus.LIVE_ON_SITE ? `WIP - ${codaTitle}` : codaTitle |
There was a problem hiding this comment.
"can be" or "is" actually displayed for all current WIP questions?
| @@ -263,6 +288,10 @@ export const loadQuestionDetail = withCache('questionDetail', async (question: s | |||
| const {data} = await loadTags('NEVER_RELOAD') | |||
| allTags = Object.fromEntries(data.map((r) => [r.name, r])) as Record<string, Tag> | |||
| } | |||
| if (Object.keys(allBanners).length === 0) { | |||
There was a problem hiding this comment.
feel free to create an issue where you collect all notes about what needs to be double checked and loaded in correct order currently and deserves simplification, I might get to it during aisafety.com hackathon 🤞
| @@ -263,6 +288,10 @@ export const loadQuestionDetail = withCache('questionDetail', async (question: s | |||
| const {data} = await loadTags('NEVER_RELOAD') | |||
| allTags = Object.fromEntries(data.map((r) => [r.name, r])) as Record<string, Tag> | |||
| } | |||
| if (Object.keys(allBanners).length === 0) { | |||
| const {data} = await loadBanners('NEVER_RELOAD') | |||
There was a problem hiding this comment.
this is the only place where it's called? NEVER_RELOAD doesn't sound right, normal cache should be used with reloading in background after 10 minutes IMHO 🤔
#292
This is just adds the basic functionality, without any decent colours or images (both of which can be set in Coda)