Add CORS to /questions/$ #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprillion
approved these changes
Aug 24, 2023
| type Handler = (args: LoaderArgs) => any | ||
| export const wrapCORS = (fn: Handler) => async (args: LoaderArgs) => { | ||
| if (args.request.method == 'OPTIONS') { | ||
| return CORSOptions(args.request) |
There was a problem hiding this comment.
is any of this special to cloudflare or remix? if yes, a link to relevant documentation would be nice ... if not, if all just standard HTTP server response stuff 👍
There was a problem hiding this comment.
no. This is to get the chat bot working, which uses remix. This is all bog standard http stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chatbot is playing about at proxying this, when it could just directly call it