Make links out of search results and question titles when embedded #309
Conversation
* can be controlled by showDetails url param * I was not able to reproduce dynamic height in Softr, either CSP or it doesn't allow listening to events somehow, so this is a version more friendly for static height
app/hooks/useQuestionStateInUrl.ts
Outdated
| @@ -194,6 +196,12 @@ export default function useQuestionStateInUrl(minLogo: boolean, initialQuestions | |||
| const toggleQuestion = useCallback( | |||
| (questionProps: Question, options?: {moveToTop?: boolean; onlyRelated?: boolean}) => { | |||
| const {pageid, relatedQuestions} = questionProps | |||
|
|
|||
| if (embedWithoutDetails) { | |||
| window.open(`https://aisafety.info/?state=${pageid}_`, '_blank') | |||
There was a problem hiding this comment.
I don't like how this is getting even more magical. Would it be possible to do this somewhere closer to the actual click?
There was a problem hiding this comment.
yeah ... this was the shared code between all places that open question details, so it's kinda DRY 🏝️
we should probably render real <a> links in the version of page without details, but if we do that in current components it would be more code that is still not self-explanatory and half-magic, even if not as much as this 🤔 I will try to make that version and see which will be less horrible 😅
the real solution would be to take the old code as inspiration and do the React components from scratch with all the existing use cases in mind, but I don't have time for that on this hackathon and not really the highest priority for the site either I guess 😭
There was a problem hiding this comment.
the refactored version to use real links: #310 => discussed on Discord that looks better => updating this branch
Improvements for #307 => testing on https://aisafety.preview.softr.app/new
showDetailsurl param