Support shareable url with search query (q and limit) #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwnik
reviewed
Sep 4, 2023
mruwnik
previously approved these changes
Sep 4, 2023
Aprillion
force-pushed
the
shareable-search-query
branch
from
d6a849a
to
2d136db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing feature from #303 to be able to share url to search results instead of just directly to answer.
Some fixes for URL state when overwriting search and using the browser back/forward buttons, seems good enough for this hidden feature, but probably not 100% bugfree yet 😅
Testable in https://stampy-ui.aprillion.workers.dev/?q=why&limit=100