split test steps without duplicate build, fix lock file #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @jrhender |
jrhender
reviewed
Oct 7, 2023
| @@ -15,7 +15,8 @@ jobs: | |||
| run: | | |||
| npm ci | |||
| npm run lint | |||
| npm run build | |||
There was a problem hiding this comment.
Is this because the test script is currently npm run build && jest, so npm run build is being run twice? I think this is ok as an optimization, however my concern would be that if the test script changes, then the CI is no longer running a build.
There was a problem hiding this comment.
well, if the test fails because of not running a build, we will notice 😅
| @@ -49,7 +49,7 @@ | |||
| "wrangler": "^2.10.0" | |||
| }, | |||
| "engines": { | |||
| "node": ">=16" | |||
| "node": ">=18" | |||
There was a problem hiding this comment.
Ah thanks, perhaps I forgot to run npm install to update package-lock after increasing the engine version in package.json 🤔 ?
There was a problem hiding this comment.
yup, fortunately no other changes were missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.