Dropdown menu #344
Dropdown menu #344
Conversation
mruwnik
commented
Nov 1, 2023
mruwnik
commented
- Remove text from action buttons #331 while I was at it
|
|
||
| .menu-link:last-child { | ||
| border-bottom: none; | ||
| } |
There was a problem hiding this comment.
I really hope someone will come along and do proper styling of everything, so I don't have to...
There was a problem hiding this comment.
IMHO if there is no link to GH issue description and/or Figma, then there is no "proper" styling to implement 🤷
There was a problem hiding this comment.
From #285 hidden to the far right of linked Figma file
| d="M283.7 127.6h-60.6c-30.4 0-55.1 24.7-55.1 55 0 4.4 3.6 8 8 8s8-3.6 8-8c0-21.5 17.5-39.1 39.1-39.1h60.6c24.4 0 44.3 19.9 44.3 44.3 0 16.9-9.4 32.1-24.6 39.7L252.3 254c-2.6 1.4-4.3 4.2-4.3 7.1V288c0 4.4 3.6 8 8 8s8-3.6 8-8v-21.9l46.7-24.2c20.5-10.3 33.3-31 33.3-54 0-33.3-27.1-60.3-60.3-60.3zM256 328c-8.8 0-16 7.2-16 16s7.2 16 16 16 16-7.2 16-16-7.2-16-16-16zm0-296.9C114.6 31.1.9 124.2.9 239.1c0 49.6 21.4 95 57 130.7-12.5 50.4-54.3 95.3-54.8 95.8-2.2 2.3-2.8 5.7-1.5 8.7s4.1 4.8 7.3 4.8c66.3 0 116-31.8 140.6-51.4 32.7 12.3 69 19.4 107.4 19.4 141.4 0 255.1-93.1 255.1-208s-114.6-208-256-208zm0 400c-35.1 0-69.4-6.2-101.8-18.4l-8.5-2.3-7.1 5.7c-20.2 16.1-60.1 42-112.7 47.1 14.4-18.3 37.4-51.7 46.6-88.6l2.2-8.8-6.4-6.4C34.1 325.1 16 283.8 16 239.1c0-105.9 107.7-192 240-192s240 86.1 240 192-107.7 192-240 192z" | ||
| style={{ | ||
| fill: '#333', |
There was a problem hiding this comment.
this now uses the default fill colour, which will handle light/dark mode gracefully
|
should I just deploy this to a test server, rather than uploading millions of pictures? |
yes |
app/assets/icons/followup.svg
Outdated
There was a problem hiding this comment.
I'm not sure about the reversal of "asking for help" icon, the usual meaning is that the user asks for help and the site is helpful ... here the site is asking for help and the user is supposed to be helpful 🤔
How is the user supposed to know that meaning before clicking on the icon? Was this discussed on some meeting? What was the answer on that meeting, please?
There was a problem hiding this comment.
seeing it in action on https://stampy-ui.ai688.workers.dev/ the text Help Out is more visible, so maybe this is OK after all
