Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate /tags/display/$tag from /tags/$tag #380

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Separate /tags/display/$tag from /tags/$tag #380

merged 6 commits into from
Feb 9, 2024

Conversation

jrhender
Copy link
Collaborator

@jrhender jrhender commented Feb 9, 2024 •
edited
Loading

Items done in this PR

  1. Separate /tags/display/$tag from /tags/$tag. "display" is used for the page to render the tag, while /tags/$tag returns single tag JSON. As /tags/$tag is used for question rendering, it might be removed or changed if the questions/articles changes
  2. Use navigate to change the URL when navigating to a new category
  3. Remove the tags index as it isn't needed anywhere in the app
  4. Return 404 from display page if requested tag isn't found

@jrhender jrhender changed the title Render categeories page when navigating to /tags/$tag Separate /tags/display/$tag from /tags/$tag Feb 9, 2024
@jrhender jrhender marked this pull request as ready for review February 9, 2024 17:36
@jrhender jrhender force-pushed the 379-jrhender-categories-page branch 2 times, most recently from 6cab38a to eb94e9b Compare February 9, 2024 18:09
@jrhender
refactor(tag): make display tag route the main route
7ea13d7 
The old tags/$tag route is moved to tags/single/$tag.
tags/single is used by the questions route and so could be removed if questions route is removed.
@jrhender jrhender merged commit 3b0b0f8 into stampy-redesign Feb 9, 2024
1 check failed
@jrhender jrhender deleted the 379-jrhender-categories-page branch February 9, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrhender