Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin @node/types to 20.8.3 #386

Merged
merged 2 commits into from
Feb 10, 2024
Merged

pin @node/types to 20.8.3 #386

merged 2 commits into from
Feb 10, 2024

Conversation

jrhender
Copy link
Collaborator

@jrhender jrhender commented Feb 10, 2024

I noticed that stampy.ts tests are failing (e.g. https://github.com/StampyAI/stampy-ui/actions/runs/7854687158/job/21435971107) with the following error:

    app/server-utils/stampy.ts:196:45 - error TS2576: Property 'json' does not exist on type 'Response'. Did you mean to access the static member 'Response.json' instead?

    196     json = await (await fetch(url, params)).json()

I think it is due to the types conflict described here.

This PR removes @types/node to remove the conflict. This doesn't seem to break the app or any tests.

Doesn't seem to be used, as far as I can tell
@jrhender jrhender marked this pull request as ready for review February 10, 2024 13:20
Copy link
Collaborator

@Aprillion Aprillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it was probably due to stale node_modules - happened to me a few times and deleting them and reinstalling helped for me, so I guess any change in package.json "fixed" it for you :D

@jrhender jrhender merged commit 73e2b92 into stampy-redesign Feb 10, 2024
1 check passed
@jrhender jrhender deleted the npm-overrides-test-fix branch February 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants