Not sure, some stashed changes related to button #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esign # Conflicts: # package-lock.json # package.json
* use real page ids on landing page
The old tags/$tag route is moved to tags/single/$tag. tags/single is used by the questions route and so could be removed if questions route is removed.
Without slash, navigation to question from the tag display page failed. Question id was appended to /tag which isn't a route.
Makes it easier to use component in storybook
This plugin adds fix rule to easily remove unused imports
changes the route for tag pages from tags/{tag name} to tags/{tag id}/{tag name}.
Only tag id is needed to navigate to the page.
stampy.ts tests were failing (e.g. https://github.com/StampyAI/stampy-ui/actions/runs/7854687158/job/21435971107) with the following error: ``` app/server-utils/stampy.ts:196:45 - error TS2576: Property 'json' does not exist on type 'Response'. Did you mean to access the static member 'Response.json' instead? 196 json = await (await fetch(url, params)).json() ``` Removed @nodes/types as I think it was due to the types conflict described cloudflare/workerd#1298.
redirect ?state urls (#382 part 1)
|
@melissasamworth I think you want to make a new branch from Is this the commit with the changes you want to merge? 72855b7 |
feat(Input): add placeholder prop and set for Menu
|
I'll close this one, as the changes are already merged, and this shouldn't go to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.