Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: article main content&buttons styling #399

Merged
merged 1 commit into from
Feb 16, 2024
Merged

style: article main content&buttons styling #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/components/Article/article.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ article .tag:hover {

article .contents a {
color: var(--colors-teal-500);
font-weight: bolder;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No font properties should ever be specified in the CSS because we have type classes in newroot.css, always just apply one of those.

Can we only use font-weight: 400 or font-weight: 700?

}

article .contents a:visited {
Expand Down Expand Up @@ -103,3 +104,7 @@ article .footer-comtainer {
article .footer-comtainer > * {
margin: var(--spacing-8, 8px);
}

h1.teal {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add the teal-500 class to the h1

color: var(--colors-teal-500);
}
1 change: 1 addition & 0 deletions app/components/Button/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
border-radius: 5px;
display: none;
z-index: 1;
font-size: 16px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS looks fine, but can we make tooltip its own component?

}

.tooltip:hover::after {
Expand Down
Loading